-
Notifications
You must be signed in to change notification settings - Fork 36
[FSSDK-11175] Update: Implement Decision Service methods to handle CMAB #457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
FarhanAnjum-opti
wants to merge
19
commits into
master
Choose a base branch
from
farhan-anjum/FSSDK-11175-add-decision-service-methods-for-cmab
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[FSSDK-11175] Update: Implement Decision Service methods to handle CMAB #457
FarhanAnjum-opti
wants to merge
19
commits into
master
from
farhan-anjum/FSSDK-11175-add-decision-service-methods-for-cmab
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rt OptimizelyFactory
- test_optimizely.py fixed to expect new Decision objects
…er and decision service
… and ensure key is of bytes type in hash128
Mat001
requested changes
Jun 16, 2025
…add __init__.py for cmab module
…essages and add a test for handling 500 errors
…lt and updating get_variation return type to include detailed error information
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Decision Service methods to handle CMAB
Test plan
Added unit tests
Issues
FSSDK-11175